Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Lightning CSS #1206

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jeffbowen
Copy link

@jeffbowen
Copy link
Author

Uses the lightningcss-cli package: https://lightningcss.dev/docs.html#from-the-cli

@carltongibson
Copy link
Contributor

I need to ask @diox's opinion on this...

I'm +1 to LightningCSS — already using it with COMPRESS_PRECOMPILERS.

But I've also been looking at some of the older options (YUI?) and thinking we could trim them out. (Deprecate them)

So... given how small the filter here, is the solution here to document how folks create a filter for any given tool, and then reduce the amount we ship?

🤔

@jeffbowen
Copy link
Author

Oh right, guess I could just use COMPRESS_PRECOMPILERS. I'll leave it up to you guys. Yeah, if you do trim out some of the older options it might make it clearer that there's a more preferable approach for using other simple precompilers. Thanks!

@jeffbowen
Copy link
Author

Actually, guess I can't use COMPRESS_PRECOMPILERS in my case since I'm using Sass in the project I'm working on. Will stay tuned to hear what you guys think the ideal approach would be.

@diox
Copy link
Member

diox commented Oct 11, 2023

Yeah, I'd rather get rid of these kind of small classes that are wrapper around various command-line libraries. Maybe they could be grouped together in a django-compressor-contrib package or something like that with different maintainers. Or we could improve documentation to encourage users to make their own as needed like @carltongibson is suggesting.

@carltongibson
Copy link
Contributor

@jeffbowen in the meantime you can use your filter class locally no problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants