Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat migrate tokio #9

Merged
merged 5 commits into from Oct 20, 2021
Merged

Feat migrate tokio #9

merged 5 commits into from Oct 20, 2021

Conversation

dizda
Copy link
Owner

@dizda dizda commented Oct 20, 2021

No description provided.

@dizda dizda self-assigned this Oct 20, 2021
@dizda dizda merged commit 4261a20 into master Oct 20, 2021
@dizda dizda deleted the feat-migrate-tokio branch October 20, 2021 06:42
@link2xt
Copy link

link2xt commented Oct 20, 2021

@dizda What is the rationale for this? Why is this needed and why this isn't at least a feature that can be enabled/disabled?

We have recently added a dependency of fast-socks5 to https://github.com/async-email/async-smtp, https://github.com/async-email/async-imap and https://github.com/deltachat/deltachat-core-rust/, and so far deltachat-core-rust doesn't depend on tokio, only async-std.

cc @dignifiedquire, @Jikstra

@dizda
Copy link
Owner Author

dizda commented Oct 21, 2021

Hey @link2xt,

It seems that async-std is not really maintained anymore...
While Tokio's project is pretty active.
We've made the decision to move away from async-std, and as some Traits of Tokio 1.0 will be merged into std, we've made the decision to move that library completely to Tokio.

If you're willing to make a feature to switch libraries, feel free to do so.
Or you could use this Trait to switch convert your traits https://github.com/tokio-rs/tokio/blob/e31e06c5c220ed986b3809d7a69c77c8d828ca2c/tokio-util/src/compat.rs

@Jikstra
Copy link

Jikstra commented Oct 21, 2021

@link2xt i'm not too deep in the rust ecosystem/community, is that the case that async-std is not really maintained anymore?

@dizda
Copy link
Owner Author

dizda commented Oct 22, 2021

@dignifiedquire
Copy link

Project status for async-std: async-rs/async-std#992 (comment)

Tldr: it is still maintained and used in a lot of projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants