Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude some subdirectories from the package crate #446

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Exclude some subdirectories from the package crate #446

merged 1 commit into from
Aug 15, 2023

Conversation

mulkieran
Copy link
Contributor

No description provided.

@mulkieran mulkieran marked this pull request as ready for review August 7, 2023 20:09
@mulkieran
Copy link
Contributor Author

mulkieran commented Aug 7, 2023 •
edited

Tested by:

  1. Running cargo package --all-features.
  2. Verifying directories excluded not in target/package/<packagename>
  3. cd ../target/package/<packagename>.
  4. Run cargo build --features=vendored.
  5. echo $? yields 0.

Also run cargo test with excellent results.

@mulkieran mulkieran changed the title Exclude some subdirectories from the vendor package Exclude some subdirectories from the package crate Aug 7, 2023
@mulkieran mulkieran mentioned this pull request Aug 7, 2023
Closed
@mulkieran
Exclude some subdirectories from the package crate
7f74d6c 
If these packages end up in the source crate, they will get flagged by
security tools.

Also exclude the maint subdirectory. It's weird to package instructions
for making a new release of dbus in the Rust crate of dbus-rs.

Signed-off-by: mulhern <amulhern@redhat.com>
@mulkieran
Copy link
Contributor Author

@diwic I think this ought to be an extremely safe change. It excludes only files that are part of the dbus source tree pulled in by the git submodule. And exclude won't fail if directories that are excluded have stopped existing so it should work pretty nicely even if the dbus source tree changes.

@diwic diwic merged commit 7e07639 into diwic:master Aug 15, 2023
10 checks passed
@diwic
Copy link
Owner

diwic commented Aug 15, 2023

Thanks!

@mulkieran mulkieran deleted the exclude-libdbus-sys branch August 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mulkieran @diwic