Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up kube features, document crate features #345

Merged
merged 2 commits into from Jul 29, 2022

Conversation

divergentdave
Copy link
Contributor

This PR does the following:

  • Clean up the janus_server self-dev-dependency as discussed in janus_cli: kube uses rustls rather than OpenSSL even in debug builds #327.
  • Extends the create_clusters() test in janus_core to test connecting to the clusters.
  • Fix up janus_core dev-dependencies, so that cargo test -p janus_core works. (previously, this relied on Cargo coalescing features set by janus_server's dev-dependencies when running cargo test)
  • Document all of our crates' features.
  • Document the cargo run --bin janus_cli --features kube-openssl suggestion in the context of the features list.

With this, I think we can close #327.

@divergentdave divergentdave requested a review from a team as a code owner July 29, 2022 15:29
@divergentdave divergentdave merged commit e9d417d into main Jul 29, 2022
@divergentdave divergentdave deleted the david/kube-feature-cleanup branch July 29, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

janus_cli: kube uses rustls rather than OpenSSL even in debug builds
2 participants