feat/std tui #51
Closed
feat/std tui #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaggacao
commented
Apr 15, 2022
cells/std/cli/targets.go
Outdated
Comment on lines
66
to
71
| type item struct { | ||
| name string `json:"__std_name"` | ||
| organelle string `json:"__std_organelle"` | ||
| cell string `json:"__std_cell"` | ||
| clade string `json:"__std_clade"` | ||
| description string `json:"__std_description"` |
There was a problem hiding this comment.
We could add here:
readme string `json:"__std_readme`
cells/std/cli/randomitems.go
Outdated
| clades []string | ||
| cladeIndex int | ||
| descs []string | ||
| descIndex int |
There was a problem hiding this comment.
and here an appropriate implementarion for generating dummy simple markdowm readmes
YorikSar
reviewed
Apr 15, 2022
cells/std/cli/randomitems.go
Outdated
| "Sure, why not?", | ||
| } | ||
|
|
||
| r.shuffle.Do(func() { |
There was a problem hiding this comment.
r.shuffle has just been unconditionally created in this very function, so it will always execute code in this anonymous function, set "done" flag internally and will never be touched again.
cells/std/cli/randomitems.go
Outdated
| "Sure, why not?", | ||
| } | ||
|
|
||
| r.shuffle.Do(func() { |
cells/std/cli/randomitems.go
Outdated
Comment on lines
248
to
249
| r.mtx.Lock() | ||
| defer r.mtx.Unlock() |
There was a problem hiding this comment.
And also I saw only one place where these generators are called and it's very not threaded, so I don't think locks are needed here.
|
Maybe this PR is relevant? charmbracelet/bubbletea#237 |
blaggacao
force-pushed
the
main
branch
3 times, most recently
from
23bb300
to
2a134d4
Compare
|
This landed mostly in master via: ab72ee0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: std TUI
WIP: std TUI
WIP: fix filter
status with actual run command of any given action -> help to find the corresponding CI command
eg:
In a script, run: 'std //cell/organelle:target action'spinner during initial load of
__stdmetadata?to render markdown (https://github.com/knipferrc/teacup/blob/main/markdown/markdown.go) info per target in a overlay of https://github.com/charmbracelet/bubbles#viewport (add__std_readmemeta) using a dialog box:std ...correspondence CLI commands based oncobraHack this branch: