Prefer Node's core modules over file modules

[ljani]

This commit makes this resolver behave like Node does:

Core modules are always preferentially loaded if their identifier is passed to require()

Additionally this increases performance by avoiding unnecessary disk access. For example webpack calls require("crypto") in a loop.

This commit fixes #56.

[ljani]

Hmm, right, I tested the code in JavaScript without thinking too much. Turns out process.binding has been deprecated lately. Any ideas how to get list of native modules included in the runtime?

I'll close this PR until a better way is found.

[ljani]

Apparently there is Module.builtinModules, but it's only since v9.3.0. Should we fallback to using the internal API?

[coveralls]

Coverage remained the same at 81.279% when pulling 1dfbf49 on ljani:prefer-core-modules into 6ab6566 on dividab:master.

[Jontem]

We could use a hardcoded list when node < 9.3.0?

[ 'assert',
  'buffer',
  'child_process',
  'cluster',
  'crypto',
  'dgram',
  'dns',
  'domain',
  'events',
  'fs',
  'http',
  'https',
  'net',
  'os',
  'path',
  'punycode',
  'querystring',
  'readline',
  'stream',
  'string_decoder',
  'tls',
  'tty',
  'url',
  'util',
  'v8',
  'vm',
  'zlib' ]

[jonaskello]

Checking Module.builtinModules and then fallback to hardcoded array sounds good to me. @ljani what do you think?

[ljani]

Works for me, hold on...

[Jontem]

@ljani Thanks!

[ljani]

Could this be published to npm? Thanks!

[jonaskello]

Published in 3.6.0, sorry for the delay :-).