Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump json5 and strip-bom dependency #200

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions package.json
Expand Up @@ -20,7 +20,6 @@
"@types/jest": "^27.0.3",
"@types/minimist": "^1.2.2",
"@types/node": "^6.0.54",
"@types/strip-bom": "^3.0.0",
"@types/strip-json-comments": "^0.0.30",
"husky": "^4.2.5",
"jest": "^27.3.1",
Expand All @@ -33,10 +32,9 @@
"typescript": "^4.5.2"
},
"dependencies": {
"@types/json5": "^0.0.29",
"json5": "^1.0.1",
"json5": "^2.2.1",
"minimist": "^1.2.6",
"strip-bom": "^3.0.0"
"strip-bom": "^4.0.0"
},
"scripts": {
"start": "cd src && ts-node index.ts",
Expand Down
2 changes: 1 addition & 1 deletion src/options.ts
@@ -1,4 +1,4 @@
import * as minimist from "minimist";
import minimist from "minimist";

const argv = minimist(process.argv.slice(2), {
string: ["project"],
Expand Down
8 changes: 3 additions & 5 deletions src/tsconfig-loader.ts
@@ -1,9 +1,7 @@
import * as path from "path";
import * as fs from "fs";
// tslint:disable:no-require-imports
import JSON5 = require("json5");
import StripBom = require("strip-bom");
// tslint:enable:no-require-imports
import * as JSON5 from "json5";
import stripBom from "strip-bom";

/**
* Typing for the parts of tsconfig that we care about
Expand Down Expand Up @@ -121,7 +119,7 @@ export function loadTsconfig(
}

const configString = readFileSync(configFilePath);
const cleanedJson = StripBom(configString);
const cleanedJson = stripBom(configString);
const config: Tsconfig = JSON5.parse(cleanedJson);
let extendedConfig = config.extends;

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Expand Up @@ -5,7 +5,7 @@
"outDir": "./lib",
"module": "commonjs",
"target": "es5",
// "esModuleInterop": true,
"esModuleInterop": true,
"sourceMap": true,
"declaration": true,
"lib": ["es2015"],
Expand Down