Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy: Do not configure HTTP secret for proxy registry #4305

Merged
merged 1 commit into from
Apr 23, 2024
Merged

proxy: Do not configure HTTP secret for proxy registry #4305

merged 1 commit into from
Apr 23, 2024

Conversation

ialidzhikov
Copy link
Contributor

Fixes #4304

@ialidzhikov
proxy: Do not configure HTTP secret for proxy registry
127fa7e 
Signed-off-by: Ismail Alidzhikov <i.alidjikov@gmail.com>
@ialidzhikov ialidzhikov mentioned this pull request Mar 15, 2024
Closed
96 tasks
@ialidzhikov ialidzhikov marked this pull request as ready for review March 18, 2024 08:08
milosgajdos
milosgajdos approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@milosgajdos milosgajdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me 👍

@milosgajdos milosgajdos merged commit bdd3d31 into distribution:main Apr 23, 2024
16 checks passed
@ialidzhikov ialidzhikov deleted the enh/proxy-http-secret branch April 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milosgajdos milosgajdos milosgajdos approved these changes

@squizzi squizzi squizzi approved these changes

@Jamstah Jamstah Awaiting requested review from Jamstah

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

Assignees
No one assigned
Labels
area/api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proxy: Misleading warning for missing HTTP secret
3 participants
@ialidzhikov @milosgajdos @squizzi