switch to gopkg.in/yaml.v3 #4178
Conversation
thaJeztah
added
area/config
|
ah, dang; looks like this may need more work |
|
This is failing e2e (and conformance) tests but passing unit tests 🤔 |
|
yup. initially I thought it was only used for config (so thought it would be relatively "safe" to update). Not sure what's causing it. At least may mean we're missing coverage somewhere |
|
There must be a reason they did a major bump :) |
|
Yup; let me move this back to draft, and if I find some time, look what the breaking change is 😄 |
|
I've rebased this PR @thaJeztah I might have some spare cycles to look into this tomorrow. |
Looks like most other projects switched over to v3, so let's follow suit. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Thanks; yes feel free to either carry / push to this PR, or close and open a replacement (don't think I'll have time myself) ❤️ |
gopkg.in/yaml.v3 changed the way it parses YAML. See the following commit for epxplanation: go-yaml/yaml@14f799f Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com>
|
Thanks, @thaJeztah, I've found the cause. The new version of I am not entirely sure why the E2E Tests$ make start-e2e-s3-env
docker compose -f tests/docker-compose-e2e-cloud-storage.yml up -d
[+] Building 0.0s (0/0) docker:orbstack
[+] Running 4/4
✔ Container tests-minio-1 Healthy 0.0s
✔ Container tests-minio-init-1 Exited 0.0s
✔ Container tests-redis-1 Started 0.2s
✔ Container tests-registry-1 Started
$ bash ./tests/push.sh 127.0.0.0
200
latest: Pulling from library/hello-world
Digest: sha256:3155e04f30ad5e4629fac67d6789f8809d74fea22d4e9a82f757d28cee79e0c5
Status: Image is up to date for hello-world:latest
docker.io/library/hello-world:latest
The push refers to repository [127.0.0.0:5000/distribution/hello-world]
01bb4fce3eb1: Pushed
latest: digest: sha256:7e9b6e7ba2842c91cf49f3e214d04a7a496f8214356f41d81a6e6dcad11f11e3 size: 525
latest: Pulling from distribution/hello-world
Digest: sha256:7e9b6e7ba2842c91cf49f3e214d04a7a496f8214356f41d81a6e6dcad11f11e3
Status: Image is up to date for 127.0.0.0:5000/distribution/hello-world:latest
127.0.0.0:5000/distribution/hello-world:latest |
Ok, found the cause the tests fail, but I'm afraid the fix will require more |
Looks like most other projects switched over to v3, so let's follow suit.