Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otel-tracing] Initial opentelemetry support. Rebase of 3701 #3996

Closed
wants to merge 3 commits into from

Conversation

davidspek
Copy link
Collaborator

#3701 was closed due to an issue with rebasing and losing all the changes. This PR is an attempt to revive the changes from the original PR from @lengrongfu.

Original PR comment:

Local Repose workflows result : image

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 18.64% and project coverage change: -0.40% ⚠️

Comparison is base (6ccc551) 55.85% compared to head (e248ccd) 55.46%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3996      +/-   ##
==========================================
- Coverage   55.85%   55.46%   -0.40%     
==========================================
  Files         110      110              
  Lines       11069    11183     +114     
==========================================
+ Hits         6183     6203      +20     
- Misses       4193     4283      +90     
- Partials      693      697       +4     
Files Changed Coverage Δ
registry/registry.go 45.42% <0.00%> (-0.15%) ⬇️
registry/storage/cache/redis/redis.go 0.00% <0.00%> (ø)
registry/handlers/app.go 45.57% <19.23%> (-1.00%) ⬇️
configuration/configuration.go 62.80% <40.00%> (-2.30%) ⬇️
registry/storage/cache/memory/memory.go 74.54% <73.33%> (-0.46%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: David van der Spek <vanderspek.david@gmail.com>
@corhere
Copy link
Collaborator

corhere commented Dec 2, 2023

Good news: experimental OpenTelemetry tracing support has been added to the latest Google Cloud SDK! With a dependency bump and an environment variable set, tracing through the gcs driver would Just Work!

Tracing through the azure driver will be almost as easy to enable with the support built into the Azure SDK.

As for S3, otel tracing support exists... for AWS SDK v2. At least the work already put into this PR won't go to waste.

Note for anyone willing to continue this work: see #3701 (review) which is all still relevant.

@milosgajdos
Copy link
Member

Good news: experimental OpenTelemetry tracing support has been added to the latest Google Cloud SDK! With a dependency bump and an environment variable set, tracing through the gcs driver would Just Work!

I had a look into this. distribution depends on cloud.google.com/go/storage and the latest available tag for that package seems to be: v1.35.1

And it'd appear v1.35.1 still depends on cloud.google.com/go v0.110.8 which is one minor version behind what we'd like which is (v0.111.0).

Correct me if I'm wrong though, please.

@corhere
Copy link
Collaborator

corhere commented Dec 4, 2023

@milosgajdos you are wrong. We can raise the version floor of a transitive dependency in our own go.mod if we want, because all Go modules are semver by decree.

@milosgajdos
Copy link
Member

Ah, right.

Ooof I completely missed

cloud.google.com/go v0.110.0 // indirect

@milosgajdos
Copy link
Member

Closing as outdated but more importantly the basics have been put in place in #4188

@milosgajdos milosgajdos closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature:add trace features
4 participants