Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/2.7] Fix vndr and check #3001

Merged
merged 1 commit into from Dec 17, 2019
Merged

[release/2.7] Fix vndr and check #3001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion .gometalinter.json
View file
Open in desktop
Expand Up @@ -5,7 +5,6 @@
"EnableGC": true,
"Enable": [
"structcheck",
"staticcheck",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmcgowan why the removal of static check?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

static check is failing on this branch and it is not requirement. It will remain on the master branch. The number of fixes related to static check is too large to backport imo.

"unconvert",

"gofmt",
Expand Down
6 changes: 6 additions & 0 deletions vendor/github.com/aws/aws-sdk-go/go.mod
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions vendor/gopkg.in/yaml.v2/go.mod
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.