Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support external redis sentinel cluster #2886

Closed
wants to merge 1 commit into from
Closed

support external redis sentinel cluster #2886

wants to merge 1 commit into from

Conversation

jeremyxu2010
Copy link

Signed-off-by: Jeremy Xu jeremyxu2010@gmail.com

Support external redis sentinel cluster. #2885

@codecov
Copy link

codecov bot commented Mar 24, 2019

Codecov Report

Merging #2886 into master will decrease coverage by 0.05%.
The diff coverage is 23.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2886      +/-   ##
==========================================
- Coverage   60.45%   60.39%   -0.06%     
==========================================
  Files         102      102              
  Lines        8001     8025      +24     
==========================================
+ Hits         4837     4847      +10     
- Misses       2517     2523       +6     
- Partials      647      655       +8
Flag Coverage Δ
#linux 60.39% <23.33%> (-0.06%) ⬇️
Impacted Files Coverage Δ
configuration/configuration.go 65.59% <ø> (ø) ⬆️
registry/handlers/app.go 47.9% <23.33%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d62eb1...3ccdcfc. Read the comment docs.

Signed-off-by: Jeremy Xu <jeremyxu2010@gmail.com>
@jeremyxu2010
Copy link
Author

jeremyxu2010 commented Mar 29, 2019

@caervs I tried many times to improve code coverage, but still failed. Can you review the PR and tell me how to improve code coverage in this scenario?

@dmcgowan
Copy link
Collaborator

dmcgowan commented Mar 4, 2020

Let's reassess this once we have a better way to make this plugable without adding new library dependencies

@dmcgowan dmcgowan closed this Mar 4, 2020
stonezdj added a commit to stonezdj/distribution that referenced this pull request Apr 29, 2022
stonezdj added a commit to stonezdj/distribution that referenced this pull request Apr 29, 2022
@lengrongfu lengrongfu mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants