Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature:add trace features #3451

Closed
lengrongfu opened this issue Jul 6, 2021 · 7 comments
Closed

Feature:add trace features #3451

lengrongfu opened this issue Jul 6, 2021 · 7 comments

Comments

@lengrongfu
Copy link

I hope to observe my mirror distribution process through opentracing, so I hope to add the Trace function. Do you have this requirement? Can you introduce it?

@milosgajdos
Copy link
Member

This isnt on the roadmap at the moment but could be discussed if there is enough interest or even a PR that can kick off the conversation.

@lengrongfu
Copy link
Author

@milosgajdos Do you mean to submit a PR first, and then discuss based on the PR?

@lengrongfu
Copy link
Author

@milosgajdos I hope you can take the time to reply to this question, thanks.

@lengrongfu
Copy link
Author

Can these failed problems be reproduced locally? How can I solve these problems?

@lengrongfu
Copy link
Author

issue: #3475

@lengrongfu
Copy link
Author

Test Env:
Mac
Docker: 20.10.7

Otel:
docker-compose up -d

version: "2"
services:

 # Jaeger
 jaeger-all-in-one:
   image: jaegertracing/all-in-one:latest
   ports:
     - "16686:16686"
     - "14268"
     - "14250"

 # Collector
 otel-collector:
   image: ${OTELCOL_IMG}
   command: ["--config=/etc/otel-collector-config.yaml", "${OTELCOL_ARGS}"]
   volumes:
     - ./otel-collector-config.yaml:/etc/otel-collector-config.yaml
   ports:
     - "1888:1888"   # pprof extension
     - "8888:8888"   # Prometheus metrics exposed by the collector
     - "8889:8889"   # Prometheus exporter metrics
     - "13133:13133" # health_check extension
     - "53989:4317"        # OTLP gRPC receiver
     - "55670:55679" # zpages extension
   depends_on:
     - jaeger-all-in-one

distribution:

  // config
    otel:
      exporter_name: otlp
      exporter_endpoint: demo_otel-collector_1:4317
 // run command
     $ docker run -p 5000:5000 -d --name registry registry
     $ docker network connect demo_default registry

Effect:

image

gotgelf added a commit to gotgelf/distribution that referenced this issue Dec 7, 2023
This commit integrates the opentelemetry support functionality originally proposed in PR distribution#3701 by @lengrongfu into the current master branch. Due to the age and fragility of the original PR, a direct rebase proved challenging. Therefore, the changes have been moved and adjusted to align with the latest codebase.

Key adjustments include:

- Aligning the tracing code with the latest architectural changes in the main branch.

- Resolving conflicts.

All credit for the initial development of the tracing feature goes to @lengrongfu. This commit aims to build upon that foundation and bring this valuable feature into the current version of the project.

Closes distribution#3451
gotgelf added a commit to gotgelf/distribution that referenced this issue Dec 7, 2023
This commit integrates the opentelemetry support functionality originally proposed in PR distribution#3701 by @lengrongfu into the current master branch. Due to the age and fragility of the original PR, a direct rebase proved challenging. Therefore, the changes have been moved and adjusted to align with the latest codebase.

Key adjustments include:

- Aligning the tracing code with the latest architectural changes in the main branch.

- Resolving conflicts.

All credit for the initial development of the tracing feature goes to @lengrongfu. This commit aims to build upon that foundation and bring this valuable feature into the current version of the project.

Closes distribution#3451

Signed-off-by: gotgelf <gotgelf@gmail.com>
@milosgajdos
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment