Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure DISQUS to load on WordPress Block Themes via Plugin #133

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

chrisjtang
Copy link
Contributor

Description

  • Add disqus_thread id to comment section for block themes to allow for loading the Embed.
  • Add console_error message if the disqus_thread container is not on the page.
  • Add function to hide the block theme comment section before initial render to prevent it from appearing briefly before DISQUS loads.

Motivation and Context

WordPress Block Themes were released in 2022, but the DISQUS plugin hadn't been updated to load on these themes. This is an issue in general, but specifically because the newest default themes that WordPress comes with are Block Themes.

#132

How Has This Been Tested?

Confirmed on test site that DISQUS now loads on latest WordPress Themes: Twenty Twenty-Two, Twenty Twenty-Three, and Twenty Twenty-Four.

Screenshots (if appropriate):

Screen Shot 2024-02-15 at 3 55 38 PM
Screen Shot 2024-02-15 at 3 55 25 PM
Screen Shot 2024-02-15 at 3 55 09 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • All new and existing tests passed.

Debian added 3 commits February 15, 2024 23:43
…embed. also add error message if no disqus_thread id is found on the page.
…om showing briefly before disqus loads. this function is tied to the comment_form_before wordpress action.
@chrisjtang chrisjtang requested a review from tail February 16, 2024 00:08
@chrisjtang chrisjtang merged commit ab3e9d5 into master Mar 14, 2024
80 checks passed
@chrisjtang chrisjtang deleted the block-theme-compatibility branch March 14, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants