Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extension vsix #20

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix extension vsix #20

merged 1 commit into from
May 10, 2023

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented May 10, 2023

I think this is due to microsoft/vscode-vsce#432 : the modules in question don't appear to be packaged in the VSIX if not listed explicitly.

This is sort of a workaround to fix 0.0.9, which currently fails to launch with the following output in the extension host logs:

2023-05-10 17:57:02.530 [error] Activating extension disneystreaming.smithy failed due to an error:
2023-05-10 17:57:02.530 [error] Error: Cannot find module 'concat-map'
Require stack:
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/node_modules/brace-expansion/index.js
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/node_modules/minimatch/minimatch.js
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/node_modules/vscode-languageclient/lib/common/diagnostic.js
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/node_modules/vscode-languageclient/lib/common/client.js
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/node_modules/vscode-languageclient/lib/node/main.js
- /Users/kubukoz/.vscode/extensions/disneystreaming.smithy-0.0.9/out/src/extension.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js

@Baccata Baccata merged commit 8d9e8da into main May 10, 2023
3 checks passed
@Baccata Baccata deleted the fix-extension branch May 10, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants