Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rpc #170

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Feature/rpc #170

wants to merge 12 commits into from

Conversation

topi314
Copy link
Member

@topi314 topi314 commented Jul 1, 2022

No description provided.

@mlnrDev mlnrDev added this to the v1.0.0 milestone Sep 4, 2022
go.mod Show resolved Hide resolved
# Conflicts:
#	discord/activity.go
#	go.mod
#	go.sum
@dennisrijsdijk
Copy link

is there still interest in continuing RPC development? if so, I could look at picking up some work for this.

@topi314
Copy link
Member Author

topi314 commented Oct 7, 2023

If I recall correctly the status is that most stuff has been implemented, but I wasn't happy with the API design. If you have interest in picking this up I have no objections

@dennisrijsdijk
Copy link

"wasn't happy with the API design" Can you elaborate? I can see in the example that you need to manually authorize etc. Is that what you're referring to?

@topi314
Copy link
Member Author

topi314 commented Oct 7, 2023

I am referring to how the send requires a callback to be passed to handle the answer

@dennisrijsdijk
Copy link

Ah, gotcha. I've seen another library (Rich Presence only) handle it by returning the value, so it should definitely be possible to get working for this as well. I'll have a look into that.

@topi314
Copy link
Member Author

topi314 commented Oct 7, 2023

that would be the ideal solution, but ideally this would be made 100% type safe using generics which is the challenge

@topi314
Copy link
Member Author

topi314 commented Oct 7, 2023

if you want to chat more about these changes, feel free to join our discord

# Conflicts:
#	discord/application.go
#	go.mod
#	go.sum
@topi314 topi314 self-assigned this Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants