FEATURE: Add a cop that checks for potential fabricator shorthand use #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In discourse/discourse#24314, @danielwaterworth introduced the ability to use
#fab!
with a shorthand when simply fabricating a vanilla record with the same name as the assignedlet
, e.g.:can become:
What is this cop?
This PR introduces a cop that highlights places where this shorthand can be used.