DEV: Enable some cops related to RSpec subject #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink
force-pushed
the
loic-enable-leading-subject
branch
from
dd561a9
to
2bc2579
Compare
This patch enables these cops: - `RSpec/LeadingSubject` - `RSpec/EmptyLineAfterSubject` - `RSpec/NamedSubject`
Flink
force-pushed
the
loic-enable-leading-subject
branch
from
2bc2579
to
a0fd05b
Compare
Flink
commented
Jun 22, 2023
| @@ -8,6 +8,8 @@ | |||
|
|
|||
| let(:config) { RuboCop::Config.new } | |||
|
|
|||
| before { config["Discourse/NoResetColumnInformationInMigrations"]["Enabled"] = true } | |||
There was a problem hiding this comment.
This cop is disabled by default (always was it seems) but for whatever reason it was working until now.
|
This is a followup of discussions we had on discourse/discourse#22144. To better stick to the RSpec style guide, it’s simpler to enable some of the cops related to Another PR is already done to make the necessary changes in core: discourse/discourse#22225 |
CvX
approved these changes
Jun 22, 2023
|
Thanks for this @Flink , nice one 🎉 |
Flink
added a commit
to discourse/discourse
that referenced
this pull request
Jun 26, 2023
This enables cops related to RSpec `subject`. See discourse/rubocop-discourse#32
Flink
added a commit
to discourse/discourse
that referenced
this pull request
Jun 26, 2023
This enables cops related to RSpec `subject`. See discourse/rubocop-discourse#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables these cops:
RSpec/LeadingSubjectRSpec/EmptyLineAfterSubjectRSpec/NamedSubject