DEV: Honor split RuboCop gems #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drenmi
commented
Jun 9, 2023
| @@ -213,20 +213,8 @@ RSpec/VoidExpect: | |||
| RSpec/Yield: | |||
| Enabled: true | |||
|
|
|||
| Capybara/CurrentPathExpectation: | |||
| Enabled: true | |||
|
|
|||
| RSpec/Capybara/FeatureMethods: | |||
There was a problem hiding this comment.
This looks like it was missed out, but this cop remains in rubocop-rspec, and will be turned into a more generic, non-Capybara specific cop.
|
Hm. Tests also failing for me on |
|
@Drenmi Try to rebase against |
Drenmi
force-pushed
the
dev/honor-split-rubocop-gems
branch
2 times, most recently
from
cc5559b
to
3b03c8f
Compare
Drenmi
force-pushed
the
dev/honor-split-rubocop-gems
branch
from
3b03c8f
to
8f23084
Compare
Drenmi
force-pushed
the
dev/honor-split-rubocop-gems
branch
from
8f23084
to
869082a
Compare
tgxworld
approved these changes
Jan 26, 2024
Flink
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this change?
RuboCop RSpec used to contain departments for Capybara and FactoryBot cops, but those are being split out into
rubocop-capybaraandrubocop-factory_botgems respectively. This change updates our gemspec and configuration files to reflect that.It also silences the extension suggestion that otherwise shows up after each run, e.g.: