WIP: handle class_eval on serializers

discourse · Feb 19, 2024 · be2937e · be2937e
1 parent 76ca3a1
commit be2937e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/lib/rubocop/cop/discourse/plugins/no_monkey_patching.rb b/lib/rubocop/cop/discourse/plugins/no_monkey_patching.rb
@@ -9,6 +9,8 @@ class NoMonkeyPatching < Base
             "Don’t reopen existing classes. Instead, create a mixin and use `prepend`."
           MSG_CLASS_EVAL =
             "Don’t call `class_eval`. Instead, create a mixin and use `prepend`."
+          MSG_CLASS_EVAL_SERIALIZERS =
+            "Don’t call `class_eval` on a serializer. If you’re adding new methods, use `add_to_serializer`. Otherwise, create a mixin and use `prepend`."
           MSG_SERIALIZERS =
             "Don’t reopen serializers. Instead, use `add_to_serializer`."
           RESTRICT_ON_SEND = [:class_eval].freeze
@@ -18,10 +20,13 @@ class NoMonkeyPatching < Base
           MATCHER
 
           def_node_matcher :serializer?, <<~MATCHER
-            (class (const _ /Serializer$/) ...)
+            ({class send} (const _ /Serializer$/) ...)
           MATCHER
 
           def on_send(node)
+            if serializer?(node)
+              return add_offense(node, message: MSG_CLASS_EVAL_SERIALIZERS)
+            end
             add_offense(node, message: MSG_CLASS_EVAL)
           end
 

diff --git a/spec/lib/rubocop/cop/plugins/no_monkey_patching_spec.rb b/spec/lib/rubocop/cop/plugins/no_monkey_patching_spec.rb
@@ -81,7 +81,7 @@ def a_new_method
       it "registers an offense" do
         expect_offense(<<~RUBY)
           UserSerializer.class_eval do
-          ^^^^^^^^^^^^^^^^^^^^^^^^^ Discourse/Plugins/NoMonkeyPatching: Don’t call `class_eval`. [...]
+          ^^^^^^^^^^^^^^^^^^^^^^^^^ Discourse/Plugins/NoMonkeyPatching: Don’t call `class_eval` on a serializer. [...]
             def a_new_method
               :new_value
             end