DEV: Compatibility with Rails 6.1 (2) #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviltrout
approved these changes
Apr 14, 2021
|
@eviltrout merging here is fine, we just need to be careful not to bump the gem version in the lockfile for Discourse until we are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #27.
The old PR doesn't fully fix the compatibility problems; there are a few more spots that need updating to call
db_configinstead ofspecand rails now raisesActiveRecord::ConnectionNotEstablishedwhen it can't connect to a database so we need to kickoff the failover process when that exception occurs. Integration tests are now updated to use rails 6.1.3.1.