Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEV: Compatibility with Rails 6.1 #27

Merged
merged 1 commit into from Apr 13, 2021
Merged

DEV: Compatibility with Rails 6.1 #27

merged 1 commit into from Apr 13, 2021

Conversation

OsamaSayegh
Copy link
Member

ActiveRecord::Base.connection_config has been deprecated in Rails 6.1; the new alternative is ActiveRecord::Base.connection_db_config.configuration_hash which returns the same hash as the deprecated method.

This is needed for Discourse upgrade to Rails 6.1.3.1.

@OsamaSayegh OsamaSayegh mentioned this pull request Apr 13, 2021
Merged
@SamSaffron
Copy link
Member

CI failure is mimemagick fallout ... merging this in!

@SamSaffron SamSaffron merged commit 5847f68 into master Apr 13, 2021
@SamSaffron SamSaffron deleted the dev/compatibility-with-rails-6.1.3 branch April 13, 2021 23:02
@OsamaSayegh OsamaSayegh mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltrout eviltrout eviltrout approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OsamaSayegh @SamSaffron @eviltrout