Skip to content

Commit

Permalink
DEV: Move dev dependencies to gemspec (#57)
Browse files Browse the repository at this point in the history
(and add `rubocop:disable` comments to fix the build with the latest rubocop-discourse)
  • Loading branch information
CvX committed Apr 3, 2023
1 parent 9e85522 commit ba4c9ec
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 10 deletions.
9 changes: 0 additions & 9 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,3 @@ source "https://rubygems.org"

# Specify your gem's dependencies in rails_failover.gemspec
gemspec

gem "rake", "~> 12.0"
gem "rspec", "~> 3.0"
gem 'rubocop-discourse'
gem 'byebug'
gem 'redis', '~> 4.1'
gem 'pg', '~> 1.2'
gem 'activerecord', '~> 6.0'
gem 'rack'
10 changes: 9 additions & 1 deletion rails_failover.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ Gem::Specification.new do |spec|

spec.add_dependency "activerecord", "> 6.0", "< 7.1"
spec.add_dependency "railties", "> 6.0", "< 7.1"

spec.add_dependency "concurrent-ruby"

spec.add_development_dependency "rake", "~> 12.0"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rubocop-discourse"
spec.add_development_dependency "byebug"
spec.add_development_dependency "redis", "~> 4.1"
spec.add_development_dependency "pg", "~> 1.2"
spec.add_development_dependency "activerecord", "~> 6.0"
spec.add_development_dependency "rack"
end
2 changes: 2 additions & 0 deletions spec/integration/active_record_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ def stop_dummy_rails_server
system("make stop_dummy_rails_server")
end

# rubocop:disable RSpec/BeforeAfterAll
before(:all) do
start_dummy_rails_server
end

# rubocop:disable RSpec/BeforeAfterAll
after(:all) do
stop_dummy_rails_server
end
Expand Down

0 comments on commit ba4c9ec

Please sign in to comment.