DEV: Fix a flaky spec

This patch removes the random order on specs and changes how we test for
a PG exception.

.rspec

@@ -1,3 +1,3 @@
 --color
 --require spec_helper
---order rand
+--format documentation

makefile

@@ -19,6 +19,3 @@ stop_dummy_rails_server:
 
 teardown_dummy_rails_server:
 	@cd spec/support/dummy_app && (! (bundle check > /dev/null 2>&1) || BUNDLE_GEMFILE=Gemfile DISABLE_DATABASE_ENVIRONMENT_CHECK=1 RAILS_ENV=production $(BUNDLER_BIN) exec rails db:drop)
-
-db_seed_dummy_rails_server:
-	@cd spec/support/dummy_app && BUNDLE_GEMFILE=Gemfile RAILS_ENV=production $(BUNDLER_BIN) exec rails db:seed

spec/integration/active_record_spec.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "spec_helper"
+require "fileutils"
 
 RSpec.describe "ActiveRecord failover", type: :active_record do
   EXPECTED_POSTS_COUNT = "100"
@@ -15,7 +16,6 @@ def stop_dummy_rails_server
 
   def restart_dummy_rails_server
     stop_dummy_rails_server
-    system("make db_seed_dummy_rails_server")
     start_dummy_rails_server
   end
 
@@ -97,17 +97,22 @@ def restart_dummy_rails_server
     expect(response.body).to include("writing")
   end
 
-  it "should failover if PG exception is raised before ActionDispatch::DebugExceptions" do
-    flood_get("/trigger-middleware-pg-exception", times: 10) do |response|
-      expect(response.code.to_i).to eq(500)
+  context "when PG exception is raised before ActionDispatch::DebugExceptions" do
+    let(:path) do
+      Pathname.new("#{__dir__}/../support/dummy_app/triggered_from_pg_exception.writing")
     end
 
-    sleep 0.5
-    response = get("/posts")
+    after { FileUtils.rm_f(path) }
 
-    expect(response.code.to_i).to eq(200)
-    expect(response.body).to include("triggered_from_pg_exception:writing")
-  ensure
-    restart_dummy_rails_server
+    it "fails over" do
+      flood_get("/trigger-middleware-pg-exception", times: 10) do |response|
+        expect(response.code.to_i).to eq(500)
+      end
+
+      sleep 0.5
+      response = get("/posts")
+      expect(response.code.to_i).to eq(200)
+      expect(path.exist?).to be true
+    end
   end
 end

spec/support/dummy_app/app/controllers/posts_controller.rb

@@ -6,7 +6,6 @@ class PostsController < ApplicationController
   def index
     @posts_count = Post.count
     @role = request.env["rails_failover.role"]
-    @last_post_body = Post.last.body
   end
 
   def trigger_pg_server_error

spec/support/dummy_app/app/views/posts/index.html.erb

@@ -1,3 +1,2 @@
 <%= @role %>
 <%= @posts_count %>
-<%= @last_post_body %>

spec/support/dummy_app/config/initializers/trigger_pg_exception_middleware.rb

@@ -6,7 +6,7 @@ def initialize(app)
   def call(env)
     if env["REQUEST_PATH"] == "/trigger-middleware-pg-exception"
       RailsFailover::ActiveRecord.on_failover do |role|
-        Post.create!(body: "triggered_from_pg_exception:#{role}")
+        FileUtils.touch("#{Rails.root}/triggered_from_pg_exception.#{role}")
       end
       raise ::PG::UnableToSend
     else

spec/support/dummy_app/db/seeds.rb

@@ -6,5 +6,4 @@
 #   movies = Movie.create([{ name: 'Star Wars' }, { name: 'Lord of the Rings' }])
 #   Character.create(name: 'Luke', movie: movies.first)
 
-Post.delete_all
 100.times { |i| Post.create!(body: "a" * i) }