Add :long_polling_interval to Redis config blocklist #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SamSaffron @benlangfeld Hope it's alright that I ping you on this one. |
|
@henrik Thank you for the contribution and the changes look safe to me. Will you be able to add a CHANGELOG entry here and do a patch version bump? |
As discussed in discourse#330, an allowlist would be better still. This is preventing us from upgrading to Redis 5.
|
@tgxworld Done. Thank you! |
tgxworld
approved these changes
Jun 28, 2023
|
@henrik Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #330, an allowlist would be better still.
This is preventing us from upgrading to Redis 5.