Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: support custom codecs for transport #250

Merged
merged 6 commits into from May 10, 2021
Merged

Commits on May 6, 2021

  1. FEATURE: support custom codecs for transport

    Adds support for MessageBus.transport_codec which can be used to optimise
    performance of transport
    
    - Oj can be used as a serializer vs JSON which is a bit slower
    - Users can implement custom codecs
    - OjFast can be used as a serializer for efficient user_id lookups
    
    Backwards compatible change, switching codecs to OjFast will invalidate all
    existing storage.
    
    Work in progress
    SamSaffron committed May 6, 2021
    Copy the full SHA
    fe49a3d View commit details
    Browse the repository at this point in the history
  2. Corrected implementation

    Sadly spec suite is not quite passing cause encoded data explodes if
    \x00 is in the stream, need to figure out why
    
    Bench though is spectacularly good, so we are making progress
    SamSaffron committed May 6, 2021
    Copy the full SHA
    49c7200 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Improve implementation

    - Allow redis backend to handle \u0000 in exceptional cases like
    the unsupported Marshal codec
    
    - Ship only Oj and JSON codecs out of the box
    
    - Add more benchmarks to show when packing user ids helps vs hinders
    
    - Update readme
    SamSaffron committed May 7, 2021
    Copy the full SHA
    b4b4e8d View commit details
    Browse the repository at this point in the history
  2. Update bench/codecs/packed_string.rb

    Co-authored-by: Rafael Garcia <rafbgarcia@gmail.com>
    SamSaffron and rafbgarcia committed May 7, 2021
    Copy the full SHA
    06d1778 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Lint

    Co-authored-by: Rafael Garcia <rafbgarcia@gmail.com>
    benlangfeld and rafbgarcia committed May 10, 2021
    Copy the full SHA
    24c4a69 View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    501d52e View commit details
    Browse the repository at this point in the history