FIX: Add compatibility with Rails 7.1+ #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flink
force-pushed
the
loic-fix-for-rails-7.1
branch
from
796ce9c
to
6ba1253
Compare
Rails 7.1 introduced a new default logger (`ActiveSupport::BroadcastLogger`) that responds to a new method named `#broadcast_to`. Our current logger isn’t compatible with it and we’re overwriting the Rails logger. This means that a Rails 7.1 will call `#broadcast_to` on the logger which will break. This patch fixes the issue by using the new broadcast logger and adding our Logster logger to it when inside a Rails 7.1+ app. For Rails < 7.1, we continue to replace the Rails logger with the Logster one.
Flink
force-pushed
the
loic-fix-for-rails-7.1
branch
from
6ba1253
to
80c81bf
Compare
ZogStriP
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 introduced a new default logger (
ActiveSupport::BroadcastLogger) that responds to a new method named#broadcast_to.Our current logger isn’t compatible with it and we’re overwriting the Rails logger. This means that a Rails 7.1 will call
#broadcast_toon the logger which will break.This PR fixes the issue by using the new broadcast logger and adding our Logster logger to it when inside a Rails 7.1+ app.
For Rails < 7.1, we continue to replace the Rails logger with the Logster one.