Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Merge messages differing only by numbers #118

Merged
merged 3 commits into from Aug 31, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/logster/message.rb
Expand Up @@ -113,7 +113,8 @@ def self.default_env

# in its own method so it can be overridden
def grouping_hash
{ message: self.message, severity: self.severity, backtrace: self.backtrace }
message = self.message.gsub(/[0-9a-f]+/i, "🤡")
CvX marked this conversation as resolved.
Show resolved Hide resolved
{ message: message, severity: self.severity, backtrace: self.backtrace }
end

# todo - memoize?
Expand Down
18 changes: 18 additions & 0 deletions test/logster/test_redis_store.rb
Expand Up @@ -1044,6 +1044,24 @@ def test_truncated_messages_when_they_are_similar_can_still_be_merged
end
end

def test_messages_that_differ_only_by_numbers_or_hashes_are_merged
config_reset(allow_grouping: true) do
first_message = <<~TEXT
DistributedMutex("download_20450e291e8f1e5ba03ca7f20fb7d9da570c94a6"):
held for too long, expected max: 60 secs, took an extra 73 secs
TEXT
msg = @store.report(Logger::WARN, '', first_message, backtrace: caller)

second_message = <<~TEXT
DistributedMutex("download_e09ae082c60a351dedec67ed869652862b232a0b"):
held for too long, expected max: 60 secs, took an extra 287 secs
TEXT
msg2 = @store.report(Logger::WARN, '', second_message, backtrace: caller)

assert_equal(msg.key, msg2.key)
end
end

private

def config_reset(configs)
Expand Down