Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Stop env mutation to allow all chained loggers to have the same env #110

Merged
merged 2 commits into from Mar 2, 2020
Merged

FIX: Stop env mutation to allow all chained loggers to have the same env #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
519a5fe
FIX: Stop env mutation to allow all chained loggers to have the same env
OsamaSayegh Mar 1, 2020
6f37fb8
2.3.4 doesn't like duping nil
OsamaSayegh Mar 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/logster/base_store.rb
View file
Open in desktop
Expand Up @@ -156,7 +156,7 @@ def report(severity, progname, msg, opts = {})
msg = truncate_message(msg)
message = Logster::Message.new(severity, progname, msg, opts[:timestamp], count: opts[:count])

env = opts[:env] || {}
env = opts[:env]&.dup || {}
backtrace = opts[:backtrace]
if Hash === env && env[:backtrace]
# Special - passing backtrace through env
Expand Down
12 changes: 12 additions & 0 deletions test/logster/test_base_store.rb
View file
Open in desktop
Expand Up @@ -176,4 +176,16 @@ def test_log_message_is_truncated_when_above_maximum_message_length
ensure
Logster.config.maximum_message_length = orig
end

def test_chained_loggers_shouldnt_mutate_env_passed_to_them
logger = Logster::Logger.new(@store)
other_store = Logster::TestStore.new
other_logger = Logster::Logger.new(other_store)
logger.chain(other_logger)
logger.add(Logger::WARN, "this is warning", '', { env: { backtrace: '11' } })
[@store, other_store].each do |store|
assert_equal('11', store.reported.first.backtrace)
refute_includes(store.reported.first.env.keys.map(&:to_sym), :backtrace)
end
end
end