PERF: Make truncating backtraces more memory-efficient #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently we merged this PR #103 that introduced a new config that limited the message's total size to X bytes and X is 10,000 by default. If a message is above the limit, then logster will eat away from the backtrace until the message size goes below the limit. This caused a big performance regression because the implementation is not so great performance-wise; it allocates tons of string and array objects while reducing the message size.
This PR should bring the performance back to about what it was before merging #103.
Some benchmark numbers:
My benchmark script reports the same message 2000 times to Logster and measures how long it takes and how much memory is allocated.