DEV: Build/release discourse/base:release-ruby-3.3.1 for testing
#800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `ruby_3_3` job to our Github workflow which releases a `discourse/base:release-ruby-3.3.1` Docker image to allow us to test Ruby 3.3.1 before eventually changing to that version as the default.
tgxworld
force-pushed
the
build_new_image_with_ruby_3_3_1
branch
from
9901f89
to
0657f53
Compare
tgxworld
commented
May 7, 2024
| @@ -96,5 +96,5 @@ def dev_deps() | |||
| puts "Building #{images[image]}" | |||
| dev_deps() if image == :discourse_dev | |||
|
|
|||
| build(images[image]) | |||
| build(images[image], ARGV[1..-1].join(" ")) | |||
There was a problem hiding this comment.
This is to allow us to do ruby auto_build.rb base_slim --build-args="RUBY_VERSION=3.3.1"
SamSaffron
approved these changes
May 7, 2024
|
Thank you for the review @SamSaffron 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
ruby_3_3job to our Github workflow which releasesa
discourse/base:release-ruby-3.3.1Docker image to allow us to testRuby 3.3.1 before eventually changing to that version as the default.