FEATURE: Update discourse-setup to prompt for MaxMind account ID

[tgxworld]

In order to download the free MaxMind GeoLite2 databases, an account ID
and license key is required going forward. This commit updates
discourse-setup to start prompting the user to provide the MaxMind
Account ID first before asking for the MaxMind license key. If the user
does not provide the Account ID, the script will not prompt for the
license key as we assume the user has opted out.

We are aware that we don't have a reliable way to test for changes to
the discourse-setup script but it is what it is at this point in time.
We intend to invest resources in improving things in the future but now
is not the time.

Review notes

We unfortunately have to test out the changes by hand:

1. Clone this repo
2. Run sudo SKIP_CONNECTION_TEST=1 ./discourse-setup
3. Enter random values when prompted because the values don't matter.
4. The script will print out "Unfortunately, there was an error changing containers/app.yml" but we can ignore it.
5. Run sudo cat containers/app.yml | grep MAXMIND to see that the envs have been updated to the values prompted before.

[tgxworld]

@pfaffman Pinging you for visibility since you added the MAXMIND config 3 years back.

[nbianca]

Nitpick: I think this line should be 80 characters long like the ones below.

[pfaffman]

Hey! Thanks for pinging me @tgxworld ! I've been meaning to take a look at this today but the day got away from me.

Have a look at tests/README.md. It's not real tests, but it's better than nothing. You don't have to run all the stuff by hand, at least, not each one by hand.

[tgxworld]

Have a look at tests/README.md. It's not real tests, but it's better than nothing. You don't have to run all the stuff by hand, at least, not each one by hand.

I think the tests are all broken at this point, will you be able to have a look? If not, I might want to drop them instead since we have plans to revamp the launcher and discourse-setup scripts.

[pfaffman]

It could be that something changed in what the script expects since I wrote those tests. If they don't help you, then they don't help you.

It looks like values are getting set, but when it runs a second time to see if it can change already saved values, it's failing. I'm not sure how or why that would be. Ah. Here it is:

In tests/standalone:

-$DIR/../discourse-setup --skip-connection-test --skip-rebuild <<EOF
+$DIR/../discourse-setup --debug --skip-connection-test --skip-rebuild <<EOF

In discourse-setup:

then
echo "Stopping existing container in 5 seconds or Control-C to cancel."
sleep 5

• ./launcher stop $app_name
  else
  echo "DEBUG MODE ON. Not stopping the container."
  fi

• ./launcher stop $app_name
  assert_maxmind_license_key
  assert_notification_email

---

InEnglish: Previously, the launcher stop was not in the if. Also, the test script needs to call ./discourse-setup --debug --skip-connection-tests --skip-rebuild (--debug was missing). I guess that stuff got added after I last touched the tests?

Adding DEBUG=1 before it runs the second time to change settings would speed things up. But there's still something that keeps the edits from getting processed.

It's a bummer that 1234567890123456 was decided as the placeholder for not having a maxmind key.

You can check out assert_maxmind_license_key to see how to add the new required setting to files that don't have them.

I might be inclined to remove support for maxmind from discourse-setup altogether and assume that people who can configure maxmind can manage to use vim/nano to do it by hand.

I hope this helps a bit.

I'm about to leave town for a couple of weeks and don't have much time to help out. If I did, I'd try to submit a proper PR to fix the test, but I'm horrible at git.

OK. I did rookie edits in the github web interface and submitted it as two PRs. I fixed only the standalone script but assume the others need the same fix.