FIX: chat replies are not always in a thread #27023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you reply to a chat message, we [always create a thread][1]. But when the channel we're in doesn't have threading enabled, the reply is _technically_ not a thread. This changes the `in_thread?` method to check for both the presence of a `thread_id` and to ensure that the channel has `threading_enabled`. Internal ref - t/128103/3 [1]: https://github.com/discourse/discourse/blob/e6e3eaf472a0112aca882811267a260c4cc73a89/plugins/chat/app/services/chat/create_message.rb#L110-L115
ZogStriP
force-pushed
the
chat-replies-are-not-threads
branch
from
09314e7
to
088341e
Compare
jjaffeux
approved these changes
May 16, 2024
Drenmi
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you reply to a chat message, we always create a thread. But when the channel we're in doesn't have threading enabled, the reply is technically not a thread.
This changes the
in_thread?method to check for both the presence of athread_idand to ensure that the channel hasthreading_enabled.Internal ref - t/128103/3