FIX: deep linking to a message in a thread #27022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever you get a bookmark notification, a mention notification, or click on a bookmark on a message in a long thread, we should ensure we always highlight and show the proper message. Before this fix, we would correctly load the thread, but would always start at the bottom. Internal ref. t/128103
tyb-talks
approved these changes
May 15, 2024
| @@ -223,11 +223,12 @@ export default class ChatThread extends Component { | |||
|
|
|||
| this.messagesManager.clear(); | |||
|
|
|||
| findArgs.targetMessageId ??= | |||
| findArgs.target_message_id ??= | |||
There was a problem hiding this comment.
was going to ask about camelcase vs snakecase here, but then saw that we pass the findArgs into fetchMessages with snakecase anyway. 😅
There was a problem hiding this comment.
Yeah, the server is expecting snake_case and we were sending camelCase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you get a bookmark notification, a mention notification, or click on a bookmark on a message in a long thread, we should ensure we always highlight and show the proper message.
Before this fix, we would correctly load the thread, but would always start at the bottom.
Internal ref. t/128103