DEV: First pass at process_uploads script
#26662
Draft
+845
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
migrations-tooling
The `process_upload` script is meant to be a refactor of the existing uploads importer script at `/script/bulk_import/uploads_importer.rb`. This change mostly duplicates the existing implementation with minor adjustments as a first step.
This change mostly splits up various parts of the existing implementation with a lot of duplications. The idea is more to test out a potential structure for making these tasks granular and composable.
s3lase
force-pushed
the
dev/refactor-uploads-importer
branch
from
990f463
to
b5c89fb
Compare
gschlager
reviewed
Apr 23, 2024
| configure_zeitwerk("lib/common") | ||
|
|
||
| module Uploads | ||
| class CLI < Thor |
There was a problem hiding this comment.
I think it makes sense to keep CLI code in bin/process_uploads. It's not really reusable code that you'd expect to find in lib. It doesn't help with testability, either. But maybe I'm missing something, what are your arguments for putting it into lib?
There was a problem hiding this comment.
This will be great for if we ever want to compose the CLIs into a single "migration" CLI, making each a sub command will be relatively straightforward.
It doesn't help with testability, either.
Could you explain this further?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process_uploadscript is meant to be a refactor of the existing uploads importer script at/script/bulk_import/uploads_importer.rb.This change mostly duplicates the existing implementation with minor adjustments as a first step.