DEV: Add test case for syntax highlight of complex HTML #18320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 685e0da upgrade HighlightJS to version 11, which deprecates syntax highlight of complex HTML elements. See highlightjs/highlight.js#2889 This brought a regression of syntax highlighting of GitHub oneboxes, which was fixed in 09cec7d. This commit adds a test case to prevent future regressions like this one.
pmusaraj
reviewed
Sep 21, 2022
|
|
||
| let siteSettings = { autohighlight_all_code: true }, | ||
| session = { | ||
| highlightJsPath: "/assets/highlightjs/highlight-test-bundle.min.js", |
There was a problem hiding this comment.
Curious, why is it that we can't use the regular (non-test) bundle?
There was a problem hiding this comment.
Only thing I saw differently is that it's a smaller bundle, but I'm not sure why we created this thing in the first place. Maybe it was the "run tests from themes in the running app" initiative? I don't have enough context here.
There was a problem hiding this comment.
Oh, I see, it was already there... ok, nevermind.
pmusaraj
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit 685e0da upgrade HighlightJS to version 11, which deprecates
syntax highlight of complex HTML elements. See highlightjs/highlight.js#2889
This brought a regression of syntax highlighting of GitHub oneboxes,
which was fixed in 09cec7d. This commit adds a test case to prevent
future regressions like this one.