FIX: use allowlist and blocklist terminology #10209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lis2
force-pushed
the
allowlist-blocklist
branch
4 times, most recently
from
db7bd18
to
5f9d55a
Compare
lis2
force-pushed
the
allowlist-blocklist
branch
from
5f9d55a
to
8ee6a66
Compare
tgxworld
reviewed
Jul 17, 2020
lis2
force-pushed
the
allowlist-blocklist
branch
5 times, most recently
from
2d7785c
to
e57c1f8
Compare
udan11
reviewed
Jul 23, 2020
db/migrate/20200709032247_allowlist_and_blocklist_site_settings.rb
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Jul 23, 2020
tgxworld
reviewed
Jul 23, 2020
tgxworld
requested changes
Jul 23, 2020
db/migrate/20200709032247_allowlist_and_blocklist_site_settings.rb
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Jul 23, 2020
db/post_migrate/20200629232159_rename_path_whitelist_to_allowed_paths.rb
Show resolved
Hide resolved
|
I like all the choices for names, however I am concerned at how much could break when we merge this. I've made a post on our internal forum about it. |
lis2
force-pushed
the
allowlist-blocklist
branch
from
77c645d
to
82c9343
Compare
lis2
force-pushed
the
allowlist-blocklist
branch
from
3904596
to
941f4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR of the renaming whitelist to allowlist and blacklist to the blocklist.
Based on @CvX advice, I changed a few variables so they read better like for example
path_whitelist->allowed_pathsorwhitelisted_char?(c)->self.allowed_char?(c)