REFACTOR: Use a <script src> tag to start the app (#12401)

This is to help with potential CSP issues.
discourse · Mar 16, 2021 · 1c82ed9 · 1c82ed9 · discoursebot · Mar 18, 2021
1 parent dc3af28
commit 1c82ed9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/app/assets/javascripts/discourse/app/index.html b/app/assets/javascripts/discourse/app/index.html
@@ -27,18 +27,10 @@
     <div id='offscreen-content'>
     </div>
 
-    <script>
-      document.addEventListener("discourse-booted", (e) => {
-        const config = e.detail;
-        const app = require(`${config.modulePrefix}/app`)["default"].create(
-          config
-        );
-        app.start();
-      });
-    </script>
     {{bootstrap-content-for "hidden-login-form"}}
     {{bootstrap-content-for "preloaded"}}
 
+    <script src="{{rootURL}}assets/scripts/start-app.js"></script>
     <script src="{{rootURL}}assets/scripts/discourse-boot.js"></script>
 
     {{bootstrap-content-for "body-footer"}}

diff --git a/app/assets/javascripts/discourse/public/assets/scripts/start-app.js b/app/assets/javascripts/discourse/public/assets/scripts/start-app.js
@@ -0,0 +1,5 @@
+document.addEventListener("discourse-booted", (e) => {
+  const config = e.detail;
+  const app = require(`${config.modulePrefix}/app`)["default"].create(config);
+  app.start();
+});