Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Disable import/extensions #9849

Merged
merged 1 commit into from
Oct 3, 2023
Merged

build: Disable import/extensions #9849

merged 1 commit into from
Oct 3, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 22, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:
Bumping eslint-config-neon to stop import/extensions incorrectly reporting.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:25pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2023 6:25pm

@Jiralite Jiralite marked this pull request as draft October 3, 2023 18:16
@Jiralite Jiralite force-pushed the build/disable-import-extensions branch from 504b2b1 to e87be5d Compare October 3, 2023 18:16
@github-actions
Copy link

github-actions bot commented Oct 3, 2023 •
edited

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 93
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-guide-git-build-disable-import-extensions-discordjs.vercel.app/

@Jiralite Jiralite force-pushed the build/disable-import-extensions branch from e87be5d to e4d7421 Compare October 3, 2023 18:19
@Jiralite Jiralite marked this pull request as ready for review October 3, 2023 18:19
@Jiralite Jiralite requested review from a team as code owners October 3, 2023 18:19
@iCrawl iCrawl merged commit ec63818 into main Oct 3, 2023
23 checks passed
@iCrawl iCrawl deleted the build/disable-import-extensions branch October 3, 2023 19:01
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
@Jiralite
build: Disable import/extensions (discordjs#9849)
2f26166 
build: update eslint-config-neon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu vladfrangu is a code owner automatically assigned from discordjs/ws

@didinele didinele Awaiting requested review from didinele didinele is a code owner automatically assigned from discordjs/ws

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@suneettipirneni suneettipirneni Awaiting requested review from suneettipirneni suneettipirneni is a code owner automatically assigned from discordjs/util

@ckohen ckohen Awaiting requested review from ckohen ckohen is a code owner automatically assigned from discordjs/scripts

@monbrey monbrey Awaiting requested review from monbrey monbrey is a code owner automatically assigned from discordjs/guide

@almostSouji almostSouji Awaiting requested review from almostSouji almostSouji is a code owner automatically assigned from discordjs/guide

Assignees
No one assigned
Labels
apps:guide apps:website packages:brokers packages:builders packages:collection packages:core packages:create-discord-bot packages:docgen packages:formatters packages:next packages:proxy packages:proxy-container packages:rest packages:ui packages:util packages:voice packages:ws
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jiralite @iCrawl