Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Deprecate step after publish & standalone file #9837

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Sep 17, 2023

Please describe the changes this PR makes and why it should be merged:
Publishing development versions run twice daily. Deprecating packages run once daily. As a result of this, there will be two development versions not deprecated at a time for about an hour according to the times.

Deprecating prior development releases as soon as a new version is published seems ideal. This made the npm auto deprecate workflow redundant, so I've remade it into something that may be manually run by those with write access.

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 5:46pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2023 5:46pm

@github-actions
Copy link

github-actions bot commented Sep 17, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 94
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-ci-deprecate-discordjs.vercel.app/

@github-actions
Copy link

Running Lighthouse audit...

@kodiakhq kodiakhq bot merged commit 5a7b5b5 into main Sep 19, 2023
7 checks passed
@kodiakhq kodiakhq bot deleted the ci/deprecate branch September 19, 2023 17:47
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Sep 24, 2023
* ci: deprecate step after publish & standalone file

* docs: update contributing file

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants