Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(WebSocketManager): available sessions check #9823

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Conversation

didinele
Copy link
Member

@didinele didinele commented Sep 7, 2023

Please describe the changes this PR makes and why it should be merged:
See https://canary.discord.com/channels/222078108977594368/1138772709896097863/1149286266022670336

@didinele didinele requested a review from a team as a code owner September 7, 2023 11:35
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2023 0:39am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2023 0:39am

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #9823 (4285b0f) into main (c50809e) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #9823      +/-   ##
==========================================
+ Coverage   60.04%   60.06%   +0.02%     
==========================================
  Files         235      235              
  Lines       16017    16019       +2     
  Branches     1213     1215       +2     
==========================================
+ Hits         9617     9622       +5     
+ Misses       6355     6353       -2     
+ Partials       45       44       -1     
Flag Coverage Δ
next ∅ <ø> (∅)
proxy 76.31% <ø> (ø)
rest 92.77% <ø> (ø)
ws 52.63% <66.66%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/ws/src/ws/WebSocketManager.ts 96.91% <66.66%> (+0.95%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite Jiralite added this to the ws 1.1.0 milestone Sep 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 10, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 96
🟢 Best practices 100
🟠 SEO 67
🔴 PWA 33

Lighthouse ran on https://discord-js-git-fix-shard-session-check-discordjs.vercel.app/

@github-actions
Copy link

Running Lighthouse audit...

@kodiakhq kodiakhq bot merged commit e68ab16 into main Sep 10, 2023
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/shard-session-check branch September 10, 2023 12:42
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Sep 24, 2023
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@Jiralite Jiralite modified the milestones: ws 1.1.0, ws 1.0.2 Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants