Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Disable publishing multiple dev versions under the same commit #9740

Merged
merged 7 commits into from
Oct 3, 2023

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Jul 30, 2023

Please describe the changes this PR makes and why it should be merged:

Reverts some changes made in 78d013f

Status and versioning classification:

  • This PR only includes non-code changes, like changes to documentation, README, etc.

Co-authored-by: RedGuy12 <61329810+RedGuy12@users.noreply.github.com>
Co-authored-by: Rodrigo Leitão <38259440+ImRodry@users.noreply.github.com>
@jaw0r3k jaw0r3k requested a review from iCrawl as a code owner July 30, 2023 12:21
@vercel
Copy link

vercel bot commented Jul 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2023 5:11pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 27, 2023 5:11pm

@Jiralite Jiralite changed the title chore: Disable publishing multiple dev versions under the same commit ci: Disable publishing multiple dev versions under the same commit Jul 30, 2023
@Jiralite Jiralite added the ci label Jul 30, 2023
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny nit

.github/workflows/publish-dev.yml Outdated Show resolved Hide resolved
Co-authored-by: Aura Román <kyradiscord@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 18, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 92
🟠 PWA 67

Lighthouse ran on https://discord-js-git-fork-jaw0r3k-disable-mutliple-d-a7ab8c-discordjs.vercel.app/

.github/workflows/publish-dev.yml Outdated Show resolved Hide resolved
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip "Deprecate prior development releases" too. There's no point running this if the current development release is the latest.

.github/workflows/publish-dev.yml Outdated Show resolved Hide resolved
@iCrawl iCrawl merged commit 5aeb6e1 into discordjs:main Oct 3, 2023
6 checks passed
@jaw0r3k jaw0r3k deleted the disable-mutliple-dev-versions branch October 3, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Multiple dev versions are published under the same commit
5 participants