Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @discordjs/redis-gateway #9541

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

feat: @discordjs/redis-gateway #9541

wants to merge 12 commits into from

Conversation

didinele
Copy link
Member

@didinele didinele commented May 7, 2023 •
edited

Please describe the changes this PR makes and why it should be merged:
new package pog

馃 Generated by Copilot at 73ba97a

Sing, O Muse, of the mighty pull request
That brought forth the redis-gateway package
A wondrous work of the @discordjs team
Skilled in the arts of code and docker images

few notes:

  • I used this PR to document core's new Gateway
  • I've updated my name in the other licenses to my legal name due to personal reasons
  • I am yet to test this, so while I am open to reviews and feedback, it is not ready to be merged.

@didinele didinele requested review from a team and iCrawl as code owners May 7, 2023 18:50
@vercel
Copy link

vercel bot commented May 7, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git 鈫楋笌

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js 猬滐笍 Ignored (Inspect) May 8, 2023 2:06pm
discord-js-guide 猬滐笍 Ignored (Inspect) May 8, 2023 2:06pm

@didinele didinele force-pushed the feat/discord-redis-gateway branch from cc74ecb to cfbd679 Compare May 7, 2023 18:52
@didinele didinele force-pushed the feat/discord-redis-gateway branch from dbdd44d to 73ba97a Compare May 8, 2023 09:17
@codecov
Copy link

codecov bot commented May 8, 2023 •
edited

Codecov Report

Merging #9541 (d2c7c90) into main (280ed0c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #9541      +/-   ##
==========================================
+ Coverage   58.64%   58.65%   +0.01%     
==========================================
  Files         226      226              
  Lines       14790    14786       -4     
  Branches     1132     1132              
==========================================
  Hits         8673     8673              
+ Misses       6077     6073       -4     
  Partials       40       40
Flag Coverage 螖
brokers 63.16% <酶> (酶)
builders 98.69% <酶> (酶)
collection 99.88% <酶> (酶)
guide 0.00% <酶> (酶)
proxy 76.31% <酶> (酶)
rest 93.18% <酶> (酶)
util 98.49% <酶> (酶)
utilities 100.00% <酶> (酶)
voice 63.47% <酶> (酶)
website 0.00% <酶> (酶)
ws 54.30% <酶> (酶)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

馃摚 We鈥檙e building smart automated test selection to slash your CI/CD build times. Learn more

@didinele didinele force-pushed the feat/discord-redis-gateway branch from 73ba97a to 66497f1 Compare May 8, 2023 09:36
didinele and others added 2 commits May 8, 2023 15:18
@didinele @Jiralite
chore: fix typo
4444ca6 
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@didinele
chore: fix readme example
2448062
vladfrangu
vladfrangu requested changes May 8, 2023
View reviewed changes
packages/redis-gateway/README.md Outdated Show resolved Hide resolved
packages/redis-gateway/README.md Outdated Show resolved Hide resolved
packages/redis-gateway/README.md
await api.interactions.reply(interaction.id, interaction.token, { content: 'Pong!', flags: MessageFlags.Ephemeral });
});

await gateway.init('work_balancing_group', [GatewayDispatchEvents.InteractionCreate]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker but is there any way to listen to all events without needing to pass them all in (or hacking it in via Object.values(GatewayDispatchEvents))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but i dont really see when you'd want that either way if you're using a message broker, the point is to split things up depending on functionality and specifically what events said functionality needs

didinele and others added 2 commits May 8, 2023 17:02
@didinele @vladfrangu
chore: doc mistakes
92bc6d8 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@didinele
docs: constructor param in the wrong place
d2c7c90
@didinele didinele mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite left review comments

@vladfrangu vladfrangu vladfrangu requested changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
blocked packages:brokers packages:core packages:proxy packages:proxy-container packages:ws
Projects
discord.js
Status: Review in Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@didinele @vladfrangu @iCrawl @Jiralite