Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(guide): add back and forward buttons #9513

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented May 4, 2023

Please describe the changes this PR makes and why it should be merged:

Adds previous and next page buttons for easier navigation.

🤖 Generated by Copilot at 4c1884c

  • Import components and icons for navigation links (link)
  • Define variables for next and previous content items based on index (link)
  • Add div element with conditional navigation links using next and previous variables, styles, and icons (link)
  • Handle edge cases when there is no next or previous page by rendering empty div (link)

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) May 5, 2023 3:23pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 5, 2023 3:23pm

@github-actions
Copy link

github-actions bot commented May 4, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 94
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-feat-guidenext-prev-buttons-discordjs.vercel.app/guide/home/introduction

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #9513 (d345ca6) into main (51d53f5) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #9513      +/-   ##
==========================================
- Coverage   58.55%   58.45%   -0.10%     
==========================================
  Files         227      227              
  Lines       14764    14789      +25     
  Branches     1267     1267              
==========================================
  Hits         8645     8645              
- Misses       6079     6104      +25     
  Partials       40       40              
Flag Coverage Δ
guide 0.00% <0.00%> (ø)
website 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/guide/src/app/guide/[...slug]/page.tsx 0.00% <0.00%> (ø)
apps/guide/src/components/PageButton.tsx 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This reverts commit ad457a2.
Jiralite
Jiralite previously approved these changes May 4, 2023
@suneettipirneni suneettipirneni requested a review from a team as a code owner May 5, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants