fix(Activity): Fix equals() not checking for differing emoji (v13) #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eejit43 is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaw0r3k
reviewed
Nov 16, 2022
Co-authored-by: Jaworek <jaworekwiadomosci@gmail.com>
This reverts commit 3773f3f.
kyranet
changed the title
kyranet
approved these changes
Nov 19, 2022
vladfrangu
approved these changes
Nov 19, 2022
iCrawl
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Activity.equals()not checking for differing emojis, leadingpresenceUpdateto not fire if only a custom status emoji was updated.Status and versioning classification: