Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport allow deletion of ephemeral messages to v13 #8811

Merged
merged 4 commits into from Nov 25, 2022
Merged

fix: backport allow deletion of ephemeral messages to v13 #8811

merged 4 commits into from Nov 25, 2022

Conversation

Raraph84
Copy link

@Raraph84 Raraph84 commented Nov 4, 2022

Please describe the changes this PR makes and why it should be merged:
Backport allow deletion of ephemeral messages to v13 from this commit
It's my first pull request to discord.js so I don't know if I did it right

Status and versioning classification:

None

@vercel
Copy link

vercel bot commented Nov 4, 2022

@Raraph84 is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Nov 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Nov 25, 2022 at 5:24PM (UTC)

Copy link
Contributor

@MrMythicalYT MrMythicalYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error properties, like in #8774, should be deprecated.

@Raraph84
Copy link
Author

Raraph84 commented Nov 4, 2022

The error properties, like in #8774, should be deprecated.

In the precedents commits of the file Messages.js, the properties was removed, so I've just removed the concerned property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can't delete ephemeral replies on djs v13
6 participants