Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Transfomers): call .toJSON in toSnakeCase #8790

Merged
merged 5 commits into from Nov 19, 2022
Merged

fix(Transfomers): call .toJSON in toSnakeCase #8790

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8d4bb20
fix(Transfomers): call `.toJSON` in `toSnakeCase`
RedGuy12 Oct 27, 2022
2e12550
fix: move it under the Date check
RedGuy12 Oct 27, 2022
2b4ccc2
fix(toSnakeCase): stop assuming `toJSON` returns snake_case values
RedGuy12 Oct 31, 2022
2ecca62
Merge branch 'main' into gh-8742
RedGuy12 Nov 13, 2022
70277da
Merge branch 'main' into gh-8742
kodiakhq[bot] Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/discord.js/src/util/Transformers.js
View file
Open in desktop
@@ -1,5 +1,6 @@
'use strict';

const { isJSONEncodable } = require('@discordjs/util');
const snakeCase = require('lodash.snakecase');

/**
Expand All @@ -10,6 +11,7 @@ const snakeCase = require('lodash.snakecase');
function toSnakeCase(obj) {
if (typeof obj !== 'object' || !obj) return obj;
if (obj instanceof Date) return obj;
if (isJSONEncodable(obj)) return toSnakeCase(obj.toJSON());
if (Array.isArray(obj)) return obj.map(toSnakeCase);
return Object.fromEntries(Object.entries(obj).map(([key, value]) => [snakeCase(key), toSnakeCase(value)]));
}
Expand Down