New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(SlashCommandBuilder): missing methods in subcommand builder #8583
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## main #8583 +/- ##
============================================
- Coverage 100.00% 86.37% -13.63%
============================================
Files 39 87 +48
Lines 3015 8610 +5595
Branches 406 1107 +701
============================================
+ Hits 3015 7437 +4422
- Misses 0 1131 +1131
- Partials 0 42 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -188,8 +188,7 @@ export class SlashCommandBuilder { | |||
export interface SlashCommandBuilder extends SharedNameAndDescription, SharedSlashCommandOptions {} | |||
|
|||
export interface SlashCommandSubcommandsOnlyBuilder | |||
extends SharedNameAndDescription, | |||
Pick<SlashCommandBuilder, 'addSubcommand' | 'addSubcommandGroup' | 'toJSON'> {} | |||
extends Omit<SlashCommandBuilder, Exclude<keyof SharedSlashCommandOptions, 'options'>> {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this only remove the option functions or does it keep them 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It omits all the methods of the SharedSlashCommandOptions
mixin from the SlashCommandBuilder
class
Please describe the changes this PR makes and why it should be merged:
Fixes #8562
Status and versioning classification: