Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add applicationCommandMention() formatter #8280

Merged
merged 0 commits into from
Aug 22, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jul 13, 2022

Please describe the changes this PR makes and why it should be merged:

  • Added applicationCommandMention() formatted in /builders
  • Added ApplicationCommand#toString(), which will use the function mentioned above to return the commands mention

Upstream:

Status and versioning classification:

  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jul 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 0:03AM (UTC)

@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #8280 (a59d422) into main (ba6797e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #8280      +/-   ##
==========================================
+ Coverage   86.40%   86.51%   +0.11%     
==========================================
  Files          87       87              
  Lines        8221     8290      +69     
  Branches     1098     1102       +4     
==========================================
+ Hits         7103     7172      +69     
  Misses       1075     1075              
  Partials       43       43              
Flag Coverage Δ
builders 100.00% <100.00%> (ø)
collection 100.00% <ø> (ø)
proxy 73.28% <ø> (ø)
rest 92.53% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 64.08% <ø> (ø)
ws 60.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/builders/src/messages/formatters.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@almeidx almeidx force-pushed the builders/command-mention branch 3 times, most recently from da45b86 to dee1dde Compare July 13, 2022 18:53
@kyranet
Copy link
Member

kyranet commented Jul 17, 2022

This PR needs a rebase.

@almeidx
Copy link
Member Author

almeidx commented Jul 17, 2022

Rebased

@Jiralite Jiralite added this to the discord.js v14.1 milestone Jul 18, 2022
@iCrawl iCrawl added the blocked label Jul 27, 2022
@almeidx almeidx force-pushed the builders/command-mention branch 3 times, most recently from 64e4fab to a59d422 Compare July 27, 2022 11:57
@vercel vercel bot temporarily deployed to Preview July 27, 2022 12:03 Inactive
@manuelvleeuwen
Copy link
Contributor

@almeidx
Copy link
Member Author

almeidx commented Jul 30, 2022

This should also be used in https://github.com/discordjs/discord.js/blob/main/packages/discord.js/src/structures/ChatInputCommandInteraction.js

You cannot include options in command mentions

@manuelvleeuwen
Copy link
Contributor

This should also be used in https://github.com/discordjs/discord.js/blob/main/packages/discord.js/src/structures/ChatInputCommandInteraction.js

You cannot include options in command mentions

That's true, but now that there are attachment options, ChatInputCommandInteraction#toString is not 100% working anymore, and now that there is an official application command mention format, I feel like we should use the official method instead of a custom, not fully working one.

@almeidx almeidx merged commit 00990c9 into discordjs:main Aug 22, 2022
@almeidx almeidx deleted the builders/command-mention branch August 22, 2022 19:59
@almeidx almeidx restored the builders/command-mention branch August 22, 2022 20:03
@Jiralite Jiralite removed the blocked label Aug 22, 2022
@almeidx
Copy link
Member Author

almeidx commented Aug 22, 2022

Can't reopen this pull request now. Made a new one, #8546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants