typings(Util): use StringResolvable (fixes old pull) #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes my extremely old pull #3212 that didn't actually update the typing (Didn't know at the time.)
Purpzie
changed the title
iCrawl
approved these changes
Nov 4, 2019
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
Fixes my extremely old pull discordjs#3212 that didn't actually update the typing (Didn't know at the time.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes my extremely old pull #3212 that didn't actually update the typing (Didn't know at the time, I thought it just meant the jsdoc comments). Apologies! I'm not sure how I suddenly remembered 200 days later after learning some typescript.
Status
^ actually made sure this time
Semantic versioning classification: